Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop duplicate MySQL indexes. #24107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Drop duplicate MySQL indexes. #24107

wants to merge 2 commits into from
+126 −13

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Nov 22, 2024 •
edited
Loading

#24109
Duplicate indexes identified after running pt-duplicate-key-checker
https://docs.percona.com/percona-toolkit/pt-duplicate-key-checker.html

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • For database migrations:
    • Checked schema for all modified table for columns that will auto-update timestamps during migration.
    • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.
    • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

@getvictor getvictor marked this pull request as ready for review November 22, 2024 23:31
@getvictor getvictor requested a review from a team as a code owner November 22, 2024 23:31
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.41%. Comparing base (3b64f10) to head (0148f7b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ns/tables/20241122171434_RemoveDuplicateIndexes.go 95.23% 4 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #24107      +/-   ##
==========================================
- Coverage   63.42%   63.41%   -0.01%     
==========================================
  Files        1579     1580       +1     
  Lines      149950   150143     +193     
  Branches     3782     3782              
==========================================
+ Hits        95106    95217     +111     
- Misses      47262    47341      +79     
- Partials     7582     7585       +3
Flag Coverage Δ
backend 64.28% <95.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@getvictor